Break out a helper class from GenerateVisitor annotation processor. #3060
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This allows service loading all annotation processors and even determining that this one does not apply, without having javapoet in the classpath.
Result of fdb-record-layer-pr on Linux CentOS 7
|
Result of fdb-record-layer-pr on Linux CentOS 7
|
alecgrieser
previously approved these changes
Jan 24, 2025
There was a problem hiding this comment.
This looks good to me. The underlying error is a bit esoteric, but I think the idea that we should be able to construct the Processor to at least determine which annotations it processes without requiring external dependencies seems pretty defensible. We may also consider taking this on to the 4.0.559 branch
...tations/src/main/java/com/apple/foundationdb/annotation/GenerateVisitorAnnotationHelper.java
Outdated
Show resolved
Hide resolved
| import java.util.stream.Collectors; | ||
|
|
||
| @SuppressWarnings("PMD.GuardLogStatement") // confused by error invocation | ||
| class GenerateVisitorAnnotationHelper { |
There was a problem hiding this comment.
There should probably be a javadoc comment here explaining why this is a separate class from GenerateVisitorAnnotationProcessor, mostly to avoid us from doing some "harmless refactoring" in the future and putting the two classes back together again. (Likewise, we should call this out in the release notes.)
…tation/GenerateVisitorAnnotationHelper.java Co-authored-by: Alec Grieser <[email protected]>
Result of fdb-record-layer-pr on Linux CentOS 7
|
alecgrieser
approved these changes
Jan 24, 2025
Result of fdb-record-layer-pr on Linux CentOS 7
|
MMcM
added a commit
to MMcM/fdb-record-layer
that referenced
this pull request
Jan 24, 2025
…oundationDB#3060) * Break out a helper class from GenerateVisitor annotation processor. This allows service loading all annotation processors and even determining that this one does not apply, without having javapoet in the classpath.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This allows service loading all annotation processors and even determining that this one does not apply, without having javapoet in the classpath.